[Lldb-commits] [PATCH] D70797: [LLDB] Use r11 as frame pointer on Windows on ARM

Martin Storsjö via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 28 05:47:28 PST 2019


mstorsjo updated this revision to Diff 231416.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.

Added a testcase using a minidump. I had to add recognition of r11 as a potential frame pointer register in thumb mode in the handling of one instruction, to make it pick up the exact form my testcase happened to use. There's potentially other cases also where the thumb emulation doesn't expect r11 to be a frame pointer, but this at least verifies the change to GetFramePointerRegisterNumber.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70797/new/

https://reviews.llvm.org/D70797

Files:
  lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
  lldb/test/Shell/Minidump/Windows/Inputs/arm-fp-unwind.dmp.yaml
  lldb/test/Shell/Minidump/Windows/Inputs/arm-fp-unwind.exe.yaml
  lldb/test/Shell/Minidump/Windows/arm-fp-unwind.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70797.231416.patch
Type: text/x-patch
Size: 9728 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191128/d095bc30/attachment.bin>


More information about the lldb-commits mailing list