[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid updated this revision to Diff 231408.
omjavaid added a comment.

Sorry for late response on this. I got side tracked into other issues and wanted performance testing before writing an update.

I agree with @labath about making caching for limited to reads only and register writes are written all the way in latest update.

Also according to performance tests these changes show no significant improvement on real hardware but if underlying hardware is a simulator like QEMU some improvement does occur. This is the main reason I am keeping these changes intact for register reads but have removed for register writes.

I have tested this patch on Ubuntu Bionic running on QEMU and Thunder X1 arm64 server.

LGTM?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69371/new/

https://reviews.llvm.org/D69371

Files:
  lldb/include/lldb/Host/common/NativeRegisterContext.h
  lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
  lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
  lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69371.231408.patch
Type: text/x-patch
Size: 14331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191128/c5f6e67f/attachment-0001.bin>