[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

Thu Nov 28 03:16:42 PST 2019

mstorsjo added a comment.

In D70796#1762774 <https://reviews.llvm.org/D70796#1762774>, @teemperor wrote:

> This is failing for me with:
>
>   (lldb) disassemble -b -n entry
>   error: Unable to find Disassembler plug-in for the 'armv7' architecture.
>
>
> I assume that's because I run with `LLVM_TARGETS_TO_BUILD:STRING=X86;AArch64` in my CMake configuration.

Oops, sorry about that.

> Do we have a way to make this test condition on the ARM target being enabled or do we have the ARM target as a hard requirement for the test suit?

The ARM target should definitely not be a hard requirement. Is the test skipped for you if you add a `# REQUIRES: arm` line?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70796/new/

https://reviews.llvm.org/D70796