[Lldb-commits] [PATCH] D70778: [LLDB] [PECOFF] Factorize mapping section names to types using StringSwitch. NFCI.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 27 23:23:28 PST 2019


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Thanks for taking the time to do this. Just get rid of the `else`s and this is good to go.



================
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:803-804
+       (const_sect_name == g_CODE_sect_name))) {
+    return eSectionTypeCode;
+  } else if (sect.flags & llvm::COFF::IMAGE_SCN_CNT_INITIALIZED_DATA &&
+             ((const_sect_name == g_data_sect_name) ||
----------------
Now that this is a `return`, you don't need the `else` as per <http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70778/new/

https://reviews.llvm.org/D70778





More information about the lldb-commits mailing list