[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

[Paul Robinson via Phabricator via lldb-commits]

probinson added a comment.

In D49466#1761156 <https://reviews.llvm.org/D49466#1761156>, @MaskRay wrote:

> The ugly path separator pattern `{{(/|\\\\)}}` appears in 60+ tests. Can we teach clang and other tools to
>
> 1. accept both `/` and `\` input


In general they do, AFAIK, although it's not feasible in cases where `/` is the character that introduces an option, which is common on standard Windows utilities.

> 2. but only output `/`
> 
>   on Windows?

This is often actually incorrect for Windows.

> We can probably remove llvm::sys::path::Style::{windows,posix,native} from include/llvm/Support/Path.h and only keep the posix form.

It's highly unlikely that will be correct for all cases, and certainly will not match users' expectations.  Debug info, for example, will want normal Windows syntax file paths with `\`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49466/new/

https://reviews.llvm.org/D49466