[Lldb-commits] [PATCH] D70772: I implemented the features listed in this document: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0616r0.pdf and built libc++ using ninja without any errors/warnings. I Also ran the test suite it using `lit` and passed all the unit tests.
Marshall Clow via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Nov 27 12:00:58 PST 2019
mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.
This is a mess.
The changes in `libcxx/CMakeLists.txt` are unrelated to P0616.
The changes in `algorithm` are also unrelated to P0616.
The changes in `forward_list` are also unrelated to P0616, **and** are based on an outdated version of that file.
You proposed the changes in `numeric` before (in D69286 <https://reviews.llvm.org/D69286>) and then never came back to them.
And you have no tests.
Please don't keep proposing the same things over and over.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70772/new/
https://reviews.llvm.org/D70772
More information about the lldb-commits
mailing list