[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext
    Pavel Labath via Phabricator via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Wed Nov 27 02:04:35 PST 2019
    
    
  
labath added a comment.
What we've started doing these days is to just remove the "number of things appended" return value from these kinds of functions, as they make it very easy to introduce bugs. (And most callers don't care about those, and those that do, can implement this easily on their own.)
It doesn't look like this function has that many callers, so it should be easy to do the same here...
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70774/new/
https://reviews.llvm.org/D70774
    
    
More information about the lldb-commits
mailing list