[Lldb-commits] [PATCH] D70532: [lldb] Improve/fix base address selection in location lists

[Pavel Labath via Phabricator via lldb-commits]

labath marked 4 inline comments as done.
labath added inline comments.


================
Comment at: lldb/include/lldb/Expression/DWARFExpression.h:88-89
   ///
-  /// \param[in] process
-  ///     The process to use when resolving the load address
+  /// \param[in] load_function_start
+  ///     The actual address of the function containing this location list.
   ///
----------------
clayborg wrote:
> Is this a "file address"? Maybe clarify here in the comment, or rename variable appropriately?
No, this is an actual load address. The file address is only used in `SetLocationListSlide`/`SetLocationListAddresses` which then stores it in the object itself. All other functions take a load address, since that is intentionally not stored anywhere.

(Technically this doesn't have to be a load address -- it can be whatever the type of address you want. If you pass in a file address here (like some dumping code does), then it will still work, just the addresses coming out of the location list will be file addresses...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70532/new/

https://reviews.llvm.org/D70532