[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

Fri Nov 22 14:52:19 PST 2019

teemperor added a comment.

In D70324#1757070 <https://reviews.llvm.org/D70324#1757070>, @rupprecht wrote:

> In D70324#1755712 <https://reviews.llvm.org/D70324#1755712>, @davide wrote:
>
> > In D70324#1755704 <https://reviews.llvm.org/D70324#1755704>, @labath wrote:
> >
> > > [This is probably not the right patch, as the last run on that bot still doesn't have this commit.]
> >
>
>
> -> D70137 <https://reviews.llvm.org/D70137> is the correct patch that actually adds this test -- this is testonly cleanup
>
> >> My understanding is that all pexpect tests are failing on that bot and are skipped with `@skipIfAsan`. Probably this one needs to be skipped too. @teemperor was trying to reproduce some of those failures locally and failed... Maybe that bot is cursed...
> > 
> > Fair.
>
> I looked at the failure in some detail. (I don't have hardware to repro it on though). The test itself runs fine but the cleanup (I guess the `self.quit()`) at the end seems to fail: `pexpect.exceptions.ExceptionPexpect: Could not terminate the child.` Is that in line with the failures that `@skipIfAsan` is intended for?

Yeah that's the issue all expect tests have with Asan. It's related to all the timeouts in pexpect probably.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70324/new/

https://reviews.llvm.org/D70324