[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

Fri Nov 22 00:14:16 PST 2019

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good. Thanks for doing those tests.

================
Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vContThreads.py:68-72
+            "read packet: $vCont;C{0:x}:{1:x};C{0:x}:{2:x}#00".format(
+                lldbutil.get_signal_number('SIGUSR1'),
+                threads[0], threads[1]),
+            {"direction": "send", "regex": r"^\$W00#b7$"},
+        ], True)
----------------
It might be nice to actually verify how many signals did the process receive here. I guess you could do that by just checking the output of the signal handler.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70022/new/

https://reviews.llvm.org/D70022