[Lldb-commits] [PATCH] D70100: [DWARF] Handle call sites with indirect call targets

[Vedant Kumar via Phabricator via lldb-commits]

vsk marked an inline comment as done.
vsk added inline comments.


================
Comment at: lldb/include/lldb/Symbol/Function.h:453
   /// PC addresses (in increasing order).
-  llvm::MutableArrayRef<CallEdge> GetCallEdges();
+  llvm::ArrayRef<std::unique_ptr<CallEdge>> GetCallEdges();
 
----------------
aprantl wrote:
> Since DWARFExpression has a copy constructer, perhaps we should get rid of the unique_ptr to make it faster to allocate/deconstruct?
I don't think it's possible to store CallEdge directly, as it's unsized (CallEdge::GetCallee is pure virtual).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70100/new/

https://reviews.llvm.org/D70100