[Lldb-commits] [PATCH] D70415: Complete complete types early when importing types from Clang module DWARF.

Thu Nov 21 11:00:05 PST 2019

aprantl marked an inline comment as done.
aprantl added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:236
+  if (pcm_type.IsDefined())
+    GetClangASTImporter().RequireCompleteType(ClangUtil::GetQualType(type));
+
----------------
aprantl wrote:
> vsk wrote:
> > AIUI, when RequireCompleteType returns false, type completion has failed and a diagnostic is emitted. When that happens, should `ParseTypeFromClangModule` still proceed to create the type?
> I believe yes, because even the forward declaration alone will be of (limited) usefulness to represent pointer types.
That said, `pcm_type.IsDefined()` already tells us that the type has been completed successfully once, so this would be a hard situation to get into.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70415/new/

https://reviews.llvm.org/D70415