[Lldb-commits] [lldb] 24e9886 - [lldb][NFC] Reduce scope of some variables in ClangExpressionDeclMap::FindExternalVisibleDecls

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2019-11-21T13:43:48+01:00
New Revision: 24e98867937d5bb89605fd7be7e9ebdd3d5fb935

URL: https://github.com/llvm/llvm-project/commit/24e98867937d5bb89605fd7be7e9ebdd3d5fb935
DIFF: https://github.com/llvm/llvm-project/commit/24e98867937d5bb89605fd7be7e9ebdd3d5fb935.diff

LOG: [lldb][NFC] Reduce scope of some variables in ClangExpressionDeclMap::FindExternalVisibleDecls

Added: 
    

Modified: 
    lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
index 50e76be8f31b..0fdc5e266a0f 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
@@ -1223,8 +1223,6 @@ void ClangExpressionDeclMap::FindExternalVisibleDecls(
 
   Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_EXPRESSIONS));
 
-  SymbolContextList sc_list;
-
   const ConstString name(context.m_decl_name.getAsString().c_str());
   if (IgnoreName(name, false))
     return;
@@ -1288,8 +1286,6 @@ void ClangExpressionDeclMap::FindExternalVisibleDecls(
     }
     return;
   }
-  ValueObjectSP valobj;
-  VariableSP var;
 
   bool local_var_lookup =
       !namespace_decl || (namespace_decl.GetName() ==
@@ -1299,6 +1295,8 @@ void ClangExpressionDeclMap::FindExternalVisibleDecls(
       return;
 
   if (target) {
+    ValueObjectSP valobj;
+    VariableSP var;
     var = FindGlobalVariable(*target, module_sp, name, &namespace_decl,
                              nullptr);
 
@@ -1320,7 +1318,7 @@ void ClangExpressionDeclMap::FindExternalVisibleDecls(
   }
 
   const bool include_inlines = false;
-  sc_list.Clear();
+  SymbolContextList sc_list;
   if (namespace_decl && module_sp) {
     const bool include_symbols = false;