[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 20 12:29:24 PST 2019


davide added a comment.

  commit 6f4398d1b9950d48ead91b2b550792f2bbe4778e (HEAD -> master, origin/master, origin/HEAD)
  Author: Davide Italiano <ditaliano at apple.com>
  Date:   Wed Nov 20 12:27:26 2019 -0800
  
      [lldb] Fix NSURL data formatter truncation issue
      
      Remove hardcoded string prefix length assumption causing issues when
      concatenating summary for NSURL in NSURLSummaryProvider. Provider relies
      on concatenation of NSStringProvider results for summary, and while the
      strings are prefixed with '@' in Objective-C, that is not the case in
      Swift causing part of the description to be truncated.
      
      This will be tested in the downstream fork.
      
      Patch by Martin Svensson!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70393/new/

https://reviews.llvm.org/D70393





More information about the lldb-commits mailing list