[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

Martin Svensson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 19 06:18:00 PST 2019


poya added a comment.

In D70393#1751514 <https://reviews.llvm.org/D70393#1751514>, @teemperor wrote:

> But having a test for this upstream is what should ideally happen instead of just testing this downstream.


There is already a test for the NSURL data formatter upstream for the ObjC context, but the same summary provider is also used with Swift and it was only there it was being incorrectly truncated, because assumption of prefix length. So if I understood @davide correctly he wanted a test added in the Swift fork for the Swift case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70393/new/

https://reviews.llvm.org/D70393





More information about the lldb-commits mailing list