[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 19 00:33:51 PST 2019


labath added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:215
+            struct RegisterInfo *reginfo = m_reg_info.GetRegisterInfoAtIndex(i);
+            if (reginfo->byte_offset < buffer_sp->GetByteSize()) {
+              m_reg_valid[i] = true;
----------------
Should this be something like `reginfo->byte_offset+reg_info->byte_size < ...` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70417/new/

https://reviews.llvm.org/D70417





More information about the lldb-commits mailing list