[Lldb-commits] [PATCH] D70388: [lldb] Remove ClangExpressionDeclMap::ResolveUnknownTypes

[Raphael Isemann via Phabricator via lldb-commits]

teemperor created this revision.
Herald added subscribers: lldb-commits, JDevlieghere, abidh, aprantl.
Herald added a project: LLDB.

This is some really shady code. It's supposed to kick in after an expression already failed and then try to look
up "unknown types" that for some undocumented reason can't be resolved during/before parsing. Beside the
fact that we never mark any type as `EVUnknownType` in either swift-lldb or lldb (which means this code is unreachable),
this code doesn't even make the expression evaluation succeed if if would ever be executed but instead seems
to try to load more debug info that maybe any following expression evaluations might succeed.

This patch removes ClangExpressionDeclMap::ResolveUnknownTypes and the related data structures/checks/calls.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D70388

Files:
  lldb/include/lldb/Expression/ExpressionVariable.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70388.229800.patch
Type: text/x-patch
Size: 5620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191118/b8bc1656/attachment.bin>