[Lldb-commits] [PATCH] D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs

Sat Nov 16 13:44:52 PST 2019

mgorny marked an inline comment as done.
mgorny added a comment.

In D70335#1748773 <https://reviews.llvm.org/D70335#1748773>, @labath wrote:

> What's up with the new test (TestGdbRemoteTwoThreadsInvCont.py)? Is that ready for checkin or a mistake? Should it be in a separate patch?

Sorry, added accidentally. Unstaged now.

================
Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/thread-name/TestGdbRemoteThreadName.py:33
     @skipIfWindows # the test is not updated for Windows.
+    @skipIfNetBSD # build failure due to pthread_setname_np prototype
     @llgs_test
----------------
krytarowski wrote:
> Can we fix the prototype in use on NetBSD?
Sure but I'd like to address that separately.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70335/new/

https://reviews.llvm.org/D70335