[Lldb-commits] [PATCH] D70272: [-gmodules] Let LLDB log a warning if the Clang module hash mismatches.

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/source/Host/common/Host.cpp:300
   va_end(args);
+
+  // Log to log channel. This allows testcases to grep for log output.
----------------
On macOS, SystemLog vsprintf's to stderr.  So you probably don't want to put this out always.  Maybe since you don't know where SystemLog is going to print things, it would be better to only output this if the log channel is set to verbose.  That would still allow you to use it in tests, but wouldn't introduce any new output in the normal case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70272/new/

https://reviews.llvm.org/D70272