[Lldb-commits] [PATCH] D70238: [lldb] Allow loading of minidumps with no process id

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 14 05:49:16 PST 2019


labath added a comment.

Note: I am certain that there will be things which will fail for these kinds of "processes" -- there's plenty of `!= LLDB_INVALID_PID` checks, but most of them seem to be on the launch/attach code paths which are not exercised here. I am fine with fixing these as they are discovered -- the bigger question here is whether this is a reasonable direction to take lldb in. I think it is, because most of the `!= LLDB_INVALID_PID` checks look like they could be replaced by a check of the process state.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70238/new/

https://reviews.llvm.org/D70238





More information about the lldb-commits mailing list