[Lldb-commits] [lldb] bfe663c - Revert a hunk from 9634064cfa1b9bf7b7

[Reid Kleckner via lldb-commits]

Author: Reid Kleckner
Date: 2019-11-13T15:43:54-08:00
New Revision: bfe663ce22db6697459510ae5c139da2197df56c

URL: https://github.com/llvm/llvm-project/commit/bfe663ce22db6697459510ae5c139da2197df56c
DIFF: https://github.com/llvm/llvm-project/commit/bfe663ce22db6697459510ae5c139da2197df56c.diff

LOG: Revert a hunk from 9634064cfa1b9bf7b7

This causes errors when building LLDB because the Windows implementation
doesn't implement this method:

C:\src\llvm-project\lldb\source\Plugins\ScriptInterpreter\Python\ScriptInterpreterPython.cpp(915,19): error: allocating an object of abstract class type 'lldb_private::ConnectionGenericFile'
              new ConnectionGenericFile(read_file, true));
                  ^
C:\src\llvm-project\lldb\include\lldb/Utility/Connection.h(174,28): note: unimplemented pure virtual method 'GetReadObject' in 'ConnectionGenericFile'
  virtual lldb::IOObjectSP GetReadObject() = 0;
                           ^

Added: 
    

Modified: 
    lldb/include/lldb/Utility/Connection.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Utility/Connection.h b/lldb/include/lldb/Utility/Connection.h
index 2ff905d11833..9e66dee1363b 100644
--- a/lldb/include/lldb/Utility/Connection.h
+++ b/lldb/include/lldb/Utility/Connection.h
@@ -171,7 +171,7 @@ class Connection {
   ///
   /// \return
   ///     The underlying IOObject used for reading.
-  virtual lldb::IOObjectSP GetReadObject() = 0;
+  virtual lldb::IOObjectSP GetReadObject() { return lldb::IOObjectSP(); };
 
 private:
   // For Connection only