[Lldb-commits] [lldb] 9634064 - [LLDB] Fix another set of -Wdocumentation warnings
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Wed Nov 13 15:13:59 PST 2019
Author: Jonas Devlieghere
Date: 2019-11-13T15:13:06-08:00
New Revision: 9634064cfa1b9bf7b70e1cdf1f4e52a25d6184e7
URL: https://github.com/llvm/llvm-project/commit/9634064cfa1b9bf7b70e1cdf1f4e52a25d6184e7
DIFF: https://github.com/llvm/llvm-project/commit/9634064cfa1b9bf7b70e1cdf1f4e52a25d6184e7.diff
LOG: [LLDB] Fix another set of -Wdocumentation warnings
At this point I'm just fixing issues as I see them pop up locally in
incremental builds.
Added:
Modified:
lldb/include/lldb/Target/Queue.h
lldb/include/lldb/Utility/Connection.h
lldb/source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.cpp
Removed:
################################################################################
diff --git a/lldb/include/lldb/Target/Queue.h b/lldb/include/lldb/Target/Queue.h
index 01e8994f2441..10b9e0242070 100644
--- a/lldb/include/lldb/Target/Queue.h
+++ b/lldb/include/lldb/Target/Queue.h
@@ -126,10 +126,7 @@ class Queue : public std::enable_shared_from_this<Queue> {
m_pending_items.push_back(item);
}
- /// Return the kind (serial, concurrent) of this queue
- ///
- /// \return
- // Whether this is a serial or a concurrent queue
+ /// Return the kind (serial, concurrent) of this queue.
lldb::QueueKind GetKind();
void SetKind(lldb::QueueKind kind);
diff --git a/lldb/include/lldb/Utility/Connection.h b/lldb/include/lldb/Utility/Connection.h
index 77f3ef4a76ba..2ff905d11833 100644
--- a/lldb/include/lldb/Utility/Connection.h
+++ b/lldb/include/lldb/Utility/Connection.h
@@ -171,7 +171,7 @@ class Connection {
///
/// \return
/// The underlying IOObject used for reading.
- virtual lldb::IOObjectSP GetReadObject() { return lldb::IOObjectSP(); }
+ virtual lldb::IOObjectSP GetReadObject() = 0;
private:
// For Connection only
diff --git a/lldb/source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.cpp b/lldb/source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.cpp
index 50f1d48d03e0..137ecab224bc 100644
--- a/lldb/source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.cpp
+++ b/lldb/source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.cpp
@@ -207,7 +207,7 @@ bool UndefinedBehaviorSanitizerRuntime::NotifyBreakpointHit(
user_id_t break_loc_id) {
assert(baton && "null baton");
if (!baton)
- return false; //< false => resume execution.
+ return false; ///< false => resume execution.
UndefinedBehaviorSanitizerRuntime *const instance =
static_cast<UndefinedBehaviorSanitizerRuntime *>(baton);
More information about the lldb-commits
mailing list