[Lldb-commits] [PATCH] D70120: [lldb][NFC] Let CompilerType::DumpTypeValue take a option struct instead of a huge list of options

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I can't say I'm a fan of one-shot argument pack structures... For instance, one thing that's lost by this particular implementation is the implicit "nonnull" annotations on the arguments conferred by the references (the data extractor is already "nonnull", the stream isn't but it probably ought to be).

IIRC, we have a nontrivial number of functions which have a need to take a "reference" to some bitfield-y thing. For instance, the DumpDataExtractor function, which is also mentioned in this patch... Can we come up with some clever way to pack the arguments specifying the data to process into a single entity? That would replace five of these arguments by one, which should bring down the total number of arguments to this function to a reasonable size. And it would be usable in other contexts too...


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70120/new/

https://reviews.llvm.org/D70120