[Lldb-commits] [lldb] ec4c96d - [lldb][NFC] Simplify a return in ThreadPlanStepInRange::DefaultShouldStopHereCallback

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 12 01:59:32 PST 2019


Author: Raphael Isemann
Date: 2019-11-12T10:58:54+01:00
New Revision: ec4c96d68566debcc4588c4189b4ef8a5f78729a

URL: https://github.com/llvm/llvm-project/commit/ec4c96d68566debcc4588c4189b4ef8a5f78729a
DIFF: https://github.com/llvm/llvm-project/commit/ec4c96d68566debcc4588c4189b4ef8a5f78729a.diff

LOG: [lldb][NFC] Simplify a return in ThreadPlanStepInRange::DefaultShouldStopHereCallback

We know should_stop_here is false here, so we might as well return false directly.

Added: 
    

Modified: 
    lldb/source/Target/ThreadPlanStepInRange.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Target/ThreadPlanStepInRange.cpp b/lldb/source/Target/ThreadPlanStepInRange.cpp
index 71045cc7a990..77772aed516b 100644
--- a/lldb/source/Target/ThreadPlanStepInRange.cpp
+++ b/lldb/source/Target/ThreadPlanStepInRange.cpp
@@ -392,7 +392,7 @@ bool ThreadPlanStepInRange::DefaultShouldStopHereCallback(
   should_stop_here = ThreadPlanShouldStopHere::DefaultShouldStopHereCallback(
       current_plan, flags, operation, status, baton);
   if (!should_stop_here)
-    return should_stop_here;
+    return false;
 
   if (should_stop_here && current_plan->GetKind() == eKindStepInRange &&
       operation == eFrameCompareYounger) {


        


More information about the lldb-commits mailing list