[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 11 15:14:44 PST 2019


shafik marked an inline comment as done.
shafik added a comment.

In D69913#1739579 <https://reviews.llvm.org/D69913#1739579>, @jingham wrote:

> Why not have the FindFunctions lambda take a FunctionSP?  It would be easy to get the Function name out of the function in the lambda, and that would make the function more general (and also match what the Foreach does...


It was not obvious how they were using it at first, good catch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69913/new/

https://reviews.llvm.org/D69913





More information about the lldb-commits mailing list