[Lldb-commits] [PATCH] D69931: Add rpath to liblldb so vendors can ship their own python framework (or others)

[Shoaib Meenai via Phabricator via lldb-commits]

smeenai added inline comments.


================
Comment at: lldb/cmake/modules/LLDBFramework.cmake:124
+
+# Add an rpath pointing to the directory where LLDB.framework is installed.
+set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH
----------------
smeenai wrote:
> You may wanna add the reason for this to the comment as well.
Doesn't need to be super detailed ... even just adding something like "so that we can find any frameworks installed beside it" should be enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69931/new/

https://reviews.llvm.org/D69931