[Lldb-commits] [PATCH] D70070: [lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 11 02:16:53 PST 2019


teemperor created this revision.
teemperor added reviewers: labath, davide.
teemperor added a project: Upstreaming LLDB's downstream patches.
Herald added subscribers: lldb-commits, JDevlieghere.
Herald added a project: LLDB.

swift-lldb currently has to patch the ExpressionKind enum to add support for Swift expressions. If we implement LLVM's RTTI
with a static ID variable instead of a centralised enum we can drop that patch.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D70070

Files:
  lldb/include/lldb/Expression/Expression.h
  lldb/include/lldb/Expression/FunctionCaller.h
  lldb/include/lldb/Expression/LLVMUserExpression.h
  lldb/include/lldb/Expression/UserExpression.h
  lldb/include/lldb/Expression/UtilityFunction.h
  lldb/source/Expression/Expression.cpp
  lldb/source/Expression/FunctionCaller.cpp
  lldb/source/Expression/LLVMUserExpression.cpp
  lldb/source/Expression/UserExpression.cpp
  lldb/source/Expression/UtilityFunction.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70070.228652.patch
Type: text/x-patch
Size: 17136 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191111/cc9baf30/attachment-0001.bin>


More information about the lldb-commits mailing list