[Lldb-commits] [lldb] 60ab30e - Temporarily change the default for use-g-packet-for-reading to false,

[Jason Molenda via lldb-commits]

Author: Jason Molenda
Date: 2019-11-08T18:21:57-08:00
New Revision: 60ab30ebce833c87bd4776f67cd9a82fe162ef9c

URL: https://github.com/llvm/llvm-project/commit/60ab30ebce833c87bd4776f67cd9a82fe162ef9c
DIFF: https://github.com/llvm/llvm-project/commit/60ab30ebce833c87bd4776f67cd9a82fe162ef9c.diff

LOG: Temporarily change the default for use-g-packet-for-reading to false,
until we can automatically fall back to p/P if g/G are not supported;
it looks like there is a bug in debugserver's g/G packets taht needs
to be fixed, or debugserver should stop supporting g/G until that bug
is fixed.  But we need lldb to be able to fall back to p/P correctly
for that to be a viable workaround.

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py
    lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py
    lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py
index fd13b1f2cd64..8f0ed9a4933d 100644
--- a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py
+++ b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py
@@ -52,6 +52,10 @@ def vAttach(self, pid):
 
     def test_read_registers_using_g_packets(self):
         """Test reading registers using 'g' packets (default behavior)"""
+        self.dbg.HandleCommand(
+                "settings set plugin.process.gdb-remote.use-g-packet-for-reading true")
+        self.addTearDownHook(lambda: 
+                self.runCmd("settings set plugin.process.gdb-remote.use-g-packet-for-reading false"))
         self.server.responder = self.gPacketResponder()
         target = self.createTarget("a.yaml")
         process = self.connect(target)

diff  --git a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py
index b22367682030..989684c62229 100644
--- a/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py
+++ b/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py
@@ -23,7 +23,6 @@
 class TestNoGPacketSupported(GDBRemoteTestBase):
 
     @skipIfXmlSupportMissing
-    @expectedFailureAll
     def test(self):
         class MyResponder(MockGDBServerResponder):
             def haltReason(self):

diff  --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td
index 4c8202945501..9cbe3d40ca2c 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td
@@ -15,6 +15,6 @@ let Definition = "processgdbremote" in {
     Desc<"If true, the libraries-svr4 feature will be used to get a hold of the process's loaded modules.">;
   def UseGPacketForReading: Property<"use-g-packet-for-reading", "Boolean">,
     Global,
-    DefaultTrue,
+    DefaultFalse,
     Desc<"Specify if the server should use 'g' packets to read registers.">;
 }