[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

Kamil Rytarowski via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 8 13:47:58 PST 2019


krytarowski added inline comments.


================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:334
 
     thread->SetStoppedByTrace();
     SetState(StateType::eStateStopped, true);
----------------
I presume that in this code path we land into a scenario that:

1. Trap on a different LWP
2. User sets new watchpoints
3. We land here with a SIGTRAP on old watchpoint that was wiped out.

If so, we shall ignore this report, bail out and resume execution with `PT_CONTINUE`.

I think that this path could be some remnant from Linux shared trap reasons.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70025/new/

https://reviews.llvm.org/D70025





More information about the lldb-commits mailing list