[Lldb-commits] [PATCH] D70002: [lldb] Make Target* a Target& in CommandObjectExpression::DoExecute REPL logic

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 8 10:53:55 PST 2019


jingham added a comment.

As long as target.GetREPL (..., true) returns a sensible error for the Dummy target, this is fine.  Actually having the dummy target run the REPL seems like a bad idea, since that's a pretty heavy-weight activity and the dummy target is supposed to be just for priming settings for future targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70002/new/

https://reviews.llvm.org/D70002





More information about the lldb-commits mailing list