[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

[Pavel Labath via Phabricator via lldb-commits]

labath added a reviewer: beanz.
labath added a subscriber: beanz.
labath added a comment.

In D69931#1738097 <https://reviews.llvm.org/D69931#1738097>, @smeenai wrote:

> I agree on not getting into the business of installing Python ourselves, but there's also the rpath issue. The Windows case is different because you just put all your DLLs in the same directory (or some other directory in your PATH) and you're done. With macOS, you have to specify an rpath for liblldb to be able to find the Python framework. It'd be really nice to support adding additional rpaths in the build system itself (it could be a more generic mechanism; it doesn't have to be Python-specific). CMake does offer `CMAKE_INSTALL_RPATH`, but that applies to every single target. You could also use install_name_tool after building to modify the rpath, but that feels like a kludge.
>
> How would people feel about a patch that just adds the ability to set additional rpaths on liblldb?


+ @beanz for any cmake/osx/framework insights.

Having the ability to add additional rpaths to the (lib)lldb framework seems fine, if there's no other way to arrange that simply dropping dependent libraries into some directory "just works". It's not just windows where this is possible. On linux (and I assume this applies to non-framework osx builds too), you can do that by just dropping things into the "$prefix/lib" directory -- in our default setup both executables and shared libraries get the rpath of "$ORIGIN/../lib" meaning that both executables and shared libraries can find any additional deps there. Is it possible to do something like that with the framework build too? I.e., set the rpath of the LLDB.framework so that it searches for dependencies next to the framework itself? Then you'd just need to drop the python framework next to lldb...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69931/new/

https://reviews.llvm.org/D69931