[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

[Jim Ingham via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGf1539b9db39a: BreakpointDummyOptionGroup was using g_breakpoint_modify_options rather than… (authored by jingham).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69425/new/

https://reviews.llvm.org/D69425

Files:
  lldb/source/Commands/CommandObjectBreakpoint.cpp
  lldb/test/Shell/Breakpoint/Inputs/dummy-target.c
  lldb/test/Shell/Breakpoint/dummy-target.test


Index: lldb/test/Shell/Breakpoint/dummy-target.test
===================================================================
--- /dev/null
+++ lldb/test/Shell/Breakpoint/dummy-target.test
@@ -0,0 +1,23 @@
+# RUN: mkdir -p %t
+# RUN: cd %t
+# RUN: %build %p/Inputs/dummy-target.c -o dummy.out
+# RUN: %lldb -b -s %s dummy.out | FileCheck %s
+
+breakpoint set -D -n main
+# CHECK: Breakpoint {{[0-9]}}: no locations (pending).
+# CHECK: Breakpoint set in dummy target
+
+breakpoint list
+# CHECK: No breakpoints currently set
+
+breakpoint list -D
+# CHECK: name = 'main', locations = 0 (pending)
+
+target delete
+# CHECK: 1 targets deleted
+
+target create dummy.out
+# CHECK: Current executable set to {{.*}}dummy.out
+
+breakpoint list
+# CHECK: name = 'main', locations = {{[1-9]}}
Index: lldb/test/Shell/Breakpoint/Inputs/dummy-target.c
===================================================================
--- /dev/null
+++ lldb/test/Shell/Breakpoint/Inputs/dummy-target.c
@@ -0,0 +1 @@
+int main() { return 0; }
Index: lldb/source/Commands/CommandObjectBreakpoint.cpp
===================================================================
--- lldb/source/Commands/CommandObjectBreakpoint.cpp
+++ lldb/source/Commands/CommandObjectBreakpoint.cpp
@@ -180,7 +180,7 @@
                         ExecutionContext *execution_context) override {
     Status error;
     const int short_option =
-        g_breakpoint_modify_options[option_idx].short_option;
+        g_breakpoint_dummy_options[option_idx].short_option;
 
     switch (short_option) {
     case 'D':


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69425.228315.patch
Type: text/x-patch
Size: 1554 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191107/44e9d39d/attachment.bin>