[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

[Konrad Wilhelm Kleine via Phabricator via lldb-commits]

kwk accepted this revision.
kwk added a comment.
This revision is now accepted and ready to land.

LGTM with the exception of a local variable name.



================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2008
     uint32_t num_dumped = 0;
+    Mangled::NamePreference preference =
+        (m_options.m_prefer_mangled ? Mangled::ePreferMangled
----------------
How about calling this variable `name_preference`?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69944/new/

https://reviews.llvm.org/D69944