[Lldb-commits] [PATCH] D69904: [arm] Add core definition for armv8l and armv7l

Thu Nov 7 01:08:37 PST 2019

labath added a comment.

Everything except the `CoreUpdated` part LGTM. The CoreUpdated part could use another look from someone more familiar with what exactly that code was trying to achieve. And a test... I'd consider breaking that off into a separate patch.

================
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:242
 	endif
-	ifeq "$(ARCH)" "arm"
+        ifeq "$(findstring arm,$(ARCH))" "arm"
 		override ARCH :=
----------------
Whitespace issues? If the file uses spaces/tabs inconsistently, feel free to reformat in in a separate NFC patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69904/new/

https://reviews.llvm.org/D69904