[Lldb-commits] [lldb] a6b5daa - [test] Fix apple_simulator_test decorator when simulators are unavailable

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 6 15:14:13 PST 2019


Author: Alex Langford
Date: 2019-11-06T15:14:01-08:00
New Revision: a6b5daa701d3a276ace90c688f913b96d396bed1

URL: https://github.com/llvm/llvm-project/commit/a6b5daa701d3a276ace90c688f913b96d396bed1
DIFF: https://github.com/llvm/llvm-project/commit/a6b5daa701d3a276ace90c688f913b96d396bed1.diff

LOG: [test] Fix apple_simulator_test decorator when simulators are unavailable

In the case where xcodebuild fails as you set up simulator tests, you
would fail because `feature` is never defined.

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/decorators.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/decorators.py b/lldb/packages/Python/lldbsuite/test/decorators.py
index 2816cb7e39a5..10f52325875e 100644
--- a/lldb/packages/Python/lldbsuite/test/decorators.py
+++ b/lldb/packages/Python/lldbsuite/test/decorators.py
@@ -364,7 +364,7 @@ def should_skip_simulator_test():
             else:
                 return "%s simulator is not supported on this system." % platform
         except subprocess.CalledProcessError:
-            return "%s is not supported on this system (xcodebuild failed)." % feature
+            return "Simulators are unsupported on this system (xcodebuild failed)"
 
     return skipTestIfFn(should_skip_simulator_test)
 


        


More information about the lldb-commits mailing list