[Lldb-commits] [PATCH] D69871: crashlog.py: Improve regular expressions

[Adrian Prantl via Phabricator via lldb-commits]

aprantl created this revision.
aprantl added reviewers: jingham, jasonmolenda.
Herald added a subscriber: kristof.beyls.
aprantl edited the summary of this revision.

This is yet another change to the regular expressions in crashlog.py that fix a few edge cases, and attempt to improve the readability quite a bit in the process. My last change to support spaces in filenames introduced a bug that caused the version/archspec field to be parsed as part of the image name.

So in `0x1111111 - 0x22222 +MyApp Pro arm64  <01234>`, the name of the image was recognized as `MyApp Pro arm64` instead of `MyApp Pro` with a "version" of `arm64`.

The bugfix makes the space following an optional field mandatory *inside* the optional group.

rdar://problem/56883435


https://reviews.llvm.org/D69871

Files:
  lldb/examples/python/crashlog.py
  lldb/test/Shell/Python/crashlog.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69871.227982.patch
Type: text/x-patch
Size: 4653 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191106/eeb33b8b/attachment.bin>