[Lldb-commits] [lldb] 270fe47 - testsuite: skipIfNoSBHeaders should skip when running remotely

Fred Riss via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 5 12:23:42 PST 2019


Author: Fred Riss
Date: 2019-11-05T12:22:59-08:00
New Revision: 270fe47aae4ac0bf72251161ad3320de56055c3a

URL: https://github.com/llvm/llvm-project/commit/270fe47aae4ac0bf72251161ad3320de56055c3a
DIFF: https://github.com/llvm/llvm-project/commit/270fe47aae4ac0bf72251161ad3320de56055c3a.diff

LOG: testsuite: skipIfNoSBHeaders should skip when running remotely

The LLDB dylib/framework will not be available on the remote host, it makes
no sense to try to run those tests in a remote scenario.

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/decorators.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/decorators.py b/lldb/packages/Python/lldbsuite/test/decorators.py
index 5d9838f2f58a..2816cb7e39a5 100644
--- a/lldb/packages/Python/lldbsuite/test/decorators.py
+++ b/lldb/packages/Python/lldbsuite/test/decorators.py
@@ -517,6 +517,9 @@ def is_remote():
 def skipIfNoSBHeaders(func):
     """Decorate the item to mark tests that should be skipped when LLDB is built with no SB API headers."""
     def are_sb_headers_missing():
+        if lldb.remote_platform:
+            return "skip because SBHeaders tests make no sense remotely"
+
         if lldbplatformutil.getHostPlatform() == 'darwin':
             header = os.path.join(
                 os.environ["LLDB_LIB_DIR"],


        


More information about the lldb-commits mailing list