[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

Tue Nov 5 05:33:12 PST 2019

labath added a comment.

In D69793#1733774 <https://reviews.llvm.org/D69793#1733774>, @serge-sans-paille wrote:

> In D69793#1733672 <https://reviews.llvm.org/D69793#1733672>, @labath wrote:
>
> > > 1. use PyMem_RawMalloc instead of PyMem_Malloc, as expected by PyOS_Readline (prevents to segfault upon exit of interactive session)
> >
> > It looks like this is failing on python2, because it has no RawMalloc function https://docs.python.org/2.7/c-api/memory.html. I guess this bit should be `#ifdef PY2` ?
>
>
> Should be fixed by 590498829d8c0d4f4f673569949fa3850485c9c, at least this one make it work for both py2 and py3 on my laptop.

Works for me. Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69793/new/

https://reviews.llvm.org/D69793