[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

[serge via Phabricator via lldb-commits]

serge-sans-paille marked 2 inline comments as done.
serge-sans-paille added inline comments.


================
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.h:13-15
+#ifndef LLDB_DISABLE_LIBEDIT
+extern "C" PyMODINIT_FUNC initlldb_readline(void);
+#endif
----------------
labath wrote:
> How about if this file just exposes a single function like `WorkAroundLibeditIncompatibilityIfNeeded`? Then this function can be just a no-op if no work is needed, and there's no need for messy ifdefs anywhere...
I somehow achieved the same by centralizing the messy ifdefs in one explicit name :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69793/new/

https://reviews.llvm.org/D69793