[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

Haibo Huang via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 4 16:20:10 PST 2019


hhb added a comment.

In D69589#1731782 <https://reviews.llvm.org/D69589#1731782>, @aadsm wrote:

> I fixed this locally by doing this (this fix doesn't really feel good but not sure what's the best way to do it):


I found it confusing too. So finish_swig should depends on liblldb, because at least for windows, liblldb has to be exist before copying to python package path. And lldb correctly depends on both of them.

Then install-liblldb depends on liblldb. Which doesn't guarantee the build of finish_swig... Indeed your change may be the only way out...

This issue should be there before all recent changes. I'm not sure why it works before. Maybe by luck?

Do you want to upload a patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69589/new/

https://reviews.llvm.org/D69589





More information about the lldb-commits mailing list