[Lldb-commits] [lldb] df12a75 - [lldb] Also disable de-registration of EHFrames in IRExecutionUnit

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2019-11-04T09:23:37+01:00
New Revision: df12a75a19682cfeee12c38ae5113043dddffda8

URL: https://github.com/llvm/llvm-project/commit/df12a75a19682cfeee12c38ae5113043dddffda8
DIFF: https://github.com/llvm/llvm-project/commit/df12a75a19682cfeee12c38ae5113043dddffda8.diff

LOG: [lldb] Also disable de-registration of EHFrames in IRExecutionUnit

Summary:
We disabled registration by providing an empty `registerEHFrames`, so we should also provide an empty `deregisterEHFrames`
in case that function relies on `registerEHFrames` being called before. Currently `deregisterEHFrames` is a no-op anyway
as it just iterates over the (empty( list of registered EHFrames and then clear the empty list.

Reviewers: davide, JDevlieghere

Reviewed By: JDevlieghere

Subscribers: JDevlieghere, lldb-commits

Tags: #upstreaming_lldb_s_downstream_patches, #lldb

Differential Revision: https://reviews.llvm.org/D69713

Added: 
    

Modified: 
    lldb/include/lldb/Expression/IRExecutionUnit.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Expression/IRExecutionUnit.h b/lldb/include/lldb/Expression/IRExecutionUnit.h
index beff44db9d5e..f3cb7e36b2e3 100644
--- a/lldb/include/lldb/Expression/IRExecutionUnit.h
+++ b/lldb/include/lldb/Expression/IRExecutionUnit.h
@@ -298,8 +298,10 @@ class IRExecutionUnit : public std::enable_shared_from_this<IRExecutionUnit>,
       return false;
     }
 
+    // Ignore any EHFrame registration.
     void registerEHFrames(uint8_t *Addr, uint64_t LoadAddr,
                           size_t Size) override {}
+    void deregisterEHFrames() override {}
 
     uint64_t getSymbolAddress(const std::string &Name) override;