[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil requested changes to this revision.
jankratochvil added a comment.
This revision now requires changes to proceed.

On Fedora 31 x86_64 (that is with `python3-3.7.4-5.fc31.x86_64`) I get:

  FAIL: LLDB (/quad/home/jkratoch/redhat/llvm-monorepo-clangassertpython3/bin/clang-10-x86_64) :: test_ir_interpreter_int_ops (TestIRInterpreter.IRInterpreterTestCase)
  PASS: LLDB (/quad/home/jkratoch/redhat/llvm-monorepo-clangassertpython3/bin/clang-10-x86_64) :: test_type_conversions (TestIRInterpreter.IRInterpreterTestCase)
  ======================================================================
  ERROR: test_ir_interpreter_int_ops (TestIRInterpreter.IRInterpreterTestCase)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/decorators.py", line 112, in wrapper
      func(*args, **kwargs)
    File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/decorators.py", line 112, in wrapper
      func(*args, **kwargs)
    File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/decorators.py", line 112, in wrapper
      func(*args, **kwargs)
    File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py", line 130, in test_ir_interpreter_int_ops
      if not op.can_handle_operands(var1, var2):
    File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py", line 71, in can_handle_operands
      if rhs.value <= 0 or rhs.value >= 32:
  TypeError: '<=' not supported between instances of 'c_uint' and 'int'
  Config=x86_64-/quad/home/jkratoch/redhat/llvm-monorepo-clangassertpython3/bin/clang-10
  ----------------------------------------------------------------------



================
Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:69
+                # FIXME: This is probably a bug in the IRInterpreter.
+                if lhs.value <= 0:
+                    return False
----------------
Why not < 0?


================
Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:71
+                    return False
+                if rhs.value <= 0 or rhs.value >= 32:
+                    return False
----------------
Why not < 0?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67227/new/

https://reviews.llvm.org/D67227