[Lldb-commits] [PATCH] D69646: [LLDB] [PECOFF] Fix error handling for executables that object::createBinary error out on
Martin Storsjö via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 30 15:27:16 PDT 2019
mstorsjo created this revision.
mstorsjo added reviewers: labath, amccarth, aleksandr.urakov.
Herald added subscribers: JDevlieghere, abidh.
Herald added a project: LLDB.
llvm::object::createBinary returns an Expected<>, which requires not only checking the object for success, but also requires consuming the Error, if one was set.
For another similar existing case, move consuming of the Error object to a standalone std::string variable. If the Error only is consumed within a LLDB_LOGF() statement, it actually doesn't get consumed unless that log channel is enabled.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4051 bytes
Desc: not available
More information about the lldb-commits