[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 30 14:12:08 PDT 2019


teemperor added a comment.

Could this return an `Optional<std::string>` or `Expected<std::string>`? It's not clear from a `std::string` return value that the method can fail and it will return an empty string on error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69641/new/

https://reviews.llvm.org/D69641





More information about the lldb-commits mailing list