[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows
Martin Storsjö via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 30 06:32:35 PDT 2019
mstorsjo added a comment.
I presume you applied the patch with `arc patch`? It seems to apply the Phabricator username as git user, which is a bit odd, as it is customary to use realnames in the git author field. Earlier, when everything ended up mangled by svn, everything ended up normalized to the committer's name anyway, but as git preserves the author names, it would probably be good if the arc workflow could use the realname instead.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits