[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

[Saleem Abdulrasool via Phabricator via lldb-commits]

compnerd marked an inline comment as done.
compnerd added a comment.

Yeah, doing an incremental rollout makes sense.



================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:225
+  if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.13 AND CMAKE_SYSTEM_NAME STREQUAL Windows)
+    find_package(Python3 COMPONENTS Interpreter Development REQUIRED)
+    if(Python3_VERSION VERSION_LESS 3.5)
----------------
labath wrote:
> What if I use a single-config generator and build a release configuration. Is the "development" thingy still required?
Yes, it is - the component is the headers for building.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69535/new/

https://reviews.llvm.org/D69535