[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

Guilherme Andrade via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 28 16:40:49 PDT 2019

guiandrade marked an inline comment as done.
guiandrade added a comment.

In D62931#1719948 <https://reviews.llvm.org/D62931#1719948>, @labath wrote:

> I'm sorry, this dropped off my radar. The code looks fine, but it could use some more tests. For instance, one test when you set the setting value to the non-default , and then check that lldb does _not_ use the `g` packet .

Yeah, more tests would be useful. They made me notice an issue btw. I was simply sending a 'g' packet and checking if the server replied back nicely; however, IIUC with 'G' packets it isn't so simple because we also need to send the registers data in the same packet. I'm not sure how I could do that, and I'm also afraid that check could get too expensive. Do you have any idea what could be a nice way to handle that?

Thank you!

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list