[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I don't know whether this is the right way to check for this, but at the very least is seems suspicious, as this function is called from LaunchProcess, which initializes m_session_data. This means that someone else needs to clear it in the mean time, and he probably does that asynchronously. Btw, have you read the comment in OnExitProcess() ? It seems that this code already tries to handle this case somehow...

Anyway, could you add a test for this? It should not be too hard to produce a missing dll in a test.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69503/new/

https://reviews.llvm.org/D69503