[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

[Michał Górny via Phabricator via lldb-commits]

mgorny added a comment.

I'm sorry but I won't be able to test it until later today. Visually, looks good though.



================
Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:854
             files = list(i(sbf))
+            # delete them in reverse order, again because each is a borrow
+            # of the previous.
----------------
For the record, this doesn't really guarantee specific order of destruction. Generally, in Python code you shouldn't rely on destructors being called at all and close files manually. That's why `with` is commonly used with files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69488/new/

https://reviews.llvm.org/D69488