[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

[Lawrence D'Anna via Phabricator via lldb-commits]

lawrence_danna added a comment.

In D68737#1722620 <https://reviews.llvm.org/D68737#1722620>, @mgorny wrote:

> In D68737#1722575 <https://reviews.llvm.org/D68737#1722575>, @lawrence_danna wrote:
>
> > In D68737#1722255 <https://reviews.llvm.org/D68737#1722255>, @mgorny wrote:
> >
> > > However, I think this is only a symptom of a more generic problem. I don't think we should really be creating a second system of file objects outside Python, and injecting it into Python file objects like this. I have a bad feeling for e.g. creating low-level a new file object for stdin, and then having Python destroy it alongside its own stdin object.
> >
> >
> > What do you mean "a second system of file objects outside Python, and injecting it into Python file objects"?   That's not what it does.    We have 
`lldb_private::File` proxies for python files, not the other way around.
>
>
> Hmm, I guess I've been reading that code wrong. I guess I'm out of clues then.


I can reproduce it with python 2.7.    I'll post a fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68737/new/

https://reviews.llvm.org/D68737